Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: support load table infos to save memory and add gc safepoint update (#1233) #1268

Merged
merged 4 commits into from
Oct 13, 2023
Merged

drainer: support load table infos to save memory and add gc safepoint update (#1233) #1268

merged 4 commits into from
Oct 13, 2023

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Oct 13, 2023 •
edited
Loading

cherry-pick #1234 and #1239

What problem does this PR solve?

Issue Number: ref #1137

What is changed and how it works?

  1. support load table infos from tidb
  2. add gc safepoint ttl update to avoid table info is gced

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

None

@ti-chi-bot ti-chi-bot bot added the size/L label Oct 13, 2023
@lichunzhu lichunzhu changed the base branch from release-6.1 to release-6.1-20231013-v6.1.6 October 13, 2023 11:02
GMHDBJD
GMHDBJD approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@GMHDBJD: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Benjamin2037
Benjamin2037 approved these changes Oct 13, 2023
View reviewed changes
Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link

/approve

@purelind
Copy link
Collaborator

/run-integration-common-test tikv=release-6.1 pd=release-6.1 tidb=release-6.1 tidb-tools=master

@lichunzhu
Copy link
Contributor Author

/run-check tikv=release-6.1 pd=release-6.1 tidb=release-6.1 tidb-tools=master

@ti-chi-bot ti-chi-bot bot added the approved label Oct 13, 2023
@lichunzhu
Copy link
Contributor Author

/run-integration-common-test tikv=release-6.1 pd=release-6.1 tidb=release-6.1 tidb-tools=master

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@lichunzhu: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor Author

/run-integration-common-test tikv=release-6.1 pd=release-6.1 tidb=release-6.1 tidb-tools=master

@lichunzhu
Copy link
Contributor Author

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@lichunzhu: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo wuhuizuo added the lgtm label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Oct 13, 2023
@lichunzhu
Copy link
Contributor Author

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@lichunzhu: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, GMHDBJD, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [D3Hunter,GMHDBJD,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 984d839 into pingcap:release-6.1-20231013-v6.1.6 Oct 13, 2023
6 checks passed
@lichunzhu lichunzhu deleted the fixLoadTable branch October 13, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
approved lgtm release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lichunzhu @D3Hunter @purelind @Benjamin2037 @GMHDBJD @wuhuizuo @ti-chi-bot